Skip to content

fix: Removes duplicate feature descriptions #12191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: Removes duplicate feature descriptions #12191

merged 1 commit into from
Dec 19, 2024

Conversation

@kahest
Copy link
Contributor

@kahest kahest commented Dec 19, 2024 •
edited
Loading

DESCRIBE YOUR PR

Apple and Android landing pages had feature descriptions ("In addition to capturing errors,...") for the feature selector duplicated, so this PR removes the instance below the selector.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@kahest kahest requested a review from a team December 19, 2024 17:30
@vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 5:41pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Dec 19, 2024 5:41pm
develop-docs ⬜️ Ignored (Inspect) Dec 19, 2024 5:41pm

@codecov
Copy link

codecov bot commented Dec 19, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.36MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.28MB 6 bytes (-0.0%) ⬇️

@kahest kahest mentioned this pull request Dec 19, 2024
Merged
6 tasks
coolguyzone
coolguyzone approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@kahest kahest merged commit e687544 into master Dec 19, 2024
11 checks passed
@kahest kahest deleted the kahest/fix-duplicate-feature-descriptions branch December 19, 2024 22:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@coolguyzone coolguyzone coolguyzone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kahest @coolguyzone